Implemented Stable Marriage in Ruby #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
Implementation
nic-hartley
approved these changes
Nov 10, 2018
|
Will look into your suggestions next week. Thanks! |
Update stable_marriage.rb
BjoernAkAManf
commented
Nov 18, 2018
nic-hartley
approved these changes
Nov 18, 2018
There was a problem hiding this comment.
I really do not consider the display code you had self-explanatory at all. Thank you for changing it.
My complaint with shuffle! wasn't its complexity (as you said, it's hardly unusual), just that it's meant for in-place operations and you're using it to chain operations. Thank you for changing that, too.
|
I am sorry, I totally missed this review. If @nic-hartley is happy, so am I! |
leios
approved these changes
Dec 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code should be self explanatory